kezhuw commented on code in PR #2243:
URL: https://github.com/apache/zookeeper/pull/2243#discussion_r2051433517
##########
zookeeper-server/src/test/java/org/apache/zookeeper/test/ResponseCacheTest.java:
##########
@@ -146,15 +147,21 @@ public void performCacheTest(ZooKeeper zk, String path,
boolean useCache) throws
createPath(path + "/a/b/e/g", zk);
createPath(path + "/a/b/e/h", zk);
+ createPath(path + "/x", zk);
+ for (int i = 0; i < cacheSize*2; ++i) {
Review Comment:
```suggestion
for (int i = 0; i < cacheSize * 2; ++i) {
```
##########
zookeeper-server/src/test/java/org/apache/zookeeper/test/ResponseCacheTest.java:
##########
@@ -170,6 +177,19 @@ public void performCacheTest(ZooKeeper zk, String path,
boolean useCache) throws
checkCacheStatus(expectedHits, expectedMisses,
"response_packet_get_children_cache_hits",
"response_packet_get_children_cache_misses");
+
+ for (int i = 0; i < cacheSize*2; ++i) {
+ checkPath(path + "/a", zk, 2);
+ checkPath(path + "/x/y"+i, zk, 0);
Review Comment:
```suggestion
checkPath(path + "/x/y" + i, zk, 0);
```
##########
zookeeper-server/src/test/java/org/apache/zookeeper/test/ResponseCacheTest.java:
##########
@@ -170,6 +177,19 @@ public void performCacheTest(ZooKeeper zk, String path,
boolean useCache) throws
checkCacheStatus(expectedHits, expectedMisses,
"response_packet_get_children_cache_hits",
"response_packet_get_children_cache_misses");
+
+ for (int i = 0; i < cacheSize*2; ++i) {
Review Comment:
```suggestion
for (int i = 0; i < cacheSize * 2; ++i) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
