kezhuw commented on code in PR #2258: URL: https://github.com/apache/zookeeper/pull/2258#discussion_r2078850351
########## zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java: ########## @@ -903,6 +903,16 @@ public int getSnapRetainCount() { return snapRetainCount; } + /** + * Use {@link #getPurgeIntervalInMs()} instead. + * + * @return purge interval in hour unit or 0 if less than one hour. + */ + @Deprecated + public int getPurgeInterval() { Review Comment: This is the deleted version. https://github.com/apache/zookeeper/pull/2178/files ########## zookeeper-server/src/main/java/org/apache/zookeeper/server/DatadirCleanupManager.java: ########## @@ -75,7 +76,7 @@ public DatadirCleanupManager(File snapDir, File dataLogDir, int snapRetainCount, this.snapRetainCount = snapRetainCount; this.purgeIntervalInMs = purgeIntervalInMs; LOG.info("autopurge.snapRetainCount set to {}", snapRetainCount); - LOG.info("autopurge.purgeInterval set to {}", purgeIntervalInMs); + LOG.info("autopurge.purgeInterval set to {}", Time.formatTimeIntervalMs(purgeIntervalInMs)); Review Comment: Add suffix here so people have little chance to be misguarded by old versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org