stoty commented on code in PR #2270: URL: https://github.com/apache/zookeeper/pull/2270#discussion_r2193146205
########## zookeeper-server/src/main/java/org/apache/zookeeper/common/ClientX509Util.java: ########## @@ -99,6 +113,14 @@ public SslContext createNettySslContextForClient(ZKConfig config) } } + private void logTcnativeOcsp(boolean enable) { + if (enable && !OpenSsl.isOcspSupported()) { + // SslContextBuilder.enableOcsp() doesn't do anything, unless the default BoringSSL + // tcnative dependency is replaced with an OpenSsl one. + LOG.warn("Trying to enable OCSP for tcnative OpenSSL provider, but it is not supported. The setting will be ignored"); Review Comment: There is no API to get the tcnative implementation name. The closest thing I could find is OpenSsl.versionString() . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org