purushah commented on code in PR #2269:
URL: https://github.com/apache/zookeeper/pull/2269#discussion_r2199078258
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java:
##########
@@ -390,6 +393,10 @@ public void parseProperties(Properties zkProp) throws
IOException, ConfigExcepti
multiAddressReachabilityCheckEnabled = parseBoolean(key,
value);
} else if (key.equals("oraclePath")) {
oraclePath = value;
+ } else if (key.equals(QuorumAuth.QUORUM_SSL_AUTHPROVIDER)) {
+ sslAuthServerProvider = value;
+ } else if (key.equals(QuorumAuth.QUORUM_SSL_LEARNER_AUTHPROVIDER))
{
Review Comment:
I’ve always wondered why we need to pull the server-side settings from JVM
system properties when they’re almost always defined in zoo.cfg. Supporting
both adds needless complexity. It makes sense to allow client-side overrides
via –D flags, but reading the server properties that way isn’t strictly
necessary. In any event, I’ll go ahead and add the system-property support for
completeness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
