stoty commented on code in PR #2270: URL: https://github.com/apache/zookeeper/pull/2270#discussion_r2213844214
########## zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md: ########## @@ -1776,6 +1776,16 @@ and [SASL authentication for ZooKeeper](https://cwiki.apache.org/confluence/disp Specifies whether Online Certificate Status Protocol is enabled in client and quorum TLS protocols. Default: false +* *ssl.tcnative.ocsp* and *ssl.quorum.tcnative.ocsp* : Review Comment: The new server only properties would be the first of their kind, but we can add them. We can indeed document that they work differently from all the other properties. I personally think that setting those properties on the server JDK command line is a better option though. ########## zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md: ########## @@ -1776,6 +1776,16 @@ and [SASL authentication for ZooKeeper](https://cwiki.apache.org/confluence/disp Specifies whether Online Certificate Status Protocol is enabled in client and quorum TLS protocols. Default: false +* *ssl.tcnative.ocsp* and *ssl.quorum.tcnative.ocsp* : Review Comment: I still don't see why we should add more fetures to a bugfix ticket. You said that you oppose cleanup tickets, yet want to cram only tangetially related new features into this ticket. I can remove the new property for this ticket if you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
