kezhuw commented on code in PR #2248:
URL: https://github.com/apache/zookeeper/pull/2248#discussion_r2218104602
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/ContainerManager.java:
##########
@@ -50,6 +50,20 @@ public class ContainerManager {
private final Timer timer;
private final AtomicReference<TimerTask> task = new
AtomicReference<>(null);
+ /**
+ * @param zkDb the ZK database
+ * @param requestProcessor request processor - used to inject delete
+ * container requests
+ */
+ public ContainerManager(ZKDatabase zkDb, RequestProcessor
requestProcessor) {
+ this(
+ zkDb, requestProcessor,
+ Integer.getInteger("znode.container.checkIntervalMs", (int)
TimeUnit.MINUTES.toMillis(1)),
+ Integer.getInteger("znode.container.maxPerMinute", 10000),
+ Long.getLong("znode.container.maxNeverUsedIntervalMs",
TimeUnit.MINUTES.toMillis(5))
Review Comment:
How does it break things ? Container nodes with no children are supposed to
be deleted.
https://github.com/apache/zookeeper/blob/9d1d25cd75295b4529ce5348ba0cfce9ef4fefd7/zookeeper-server/src/main/java/org/apache/zookeeper/CreateMode.java#L49-L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
