li4wang commented on PR #2279: URL: https://github.com/apache/zookeeper/pull/2279#issuecomment-3111749957
> Is it possible to add the perf code to tests so others can evaluate it Do you mean to evaluate the performance improvement of this change? Any tests that perform some write operation can be used if we set the max queue size to a very small number (e.g. 1), however, the challenge is how to measure and compare the perf improvement. This is not something can be simply done by printing out some duration like the sample tests. If we analyze how `AbortPolicy()` is implemented, it's quite obvious that this change can reduce GC overhead and memory footprint when queue size exceeds the max. The perf improvement number is provided here for reference purpose. We've done quite comprehensive comparison tests w/o the change. I would be very happy to provide any clarification on the perf improvement, but personally don't think it's possible to write a meaningful perf test for it in the current code base and don't feel it's necessary neither. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
