ctubbsii commented on code in PR #2307:
URL: https://github.com/apache/zookeeper/pull/2307#discussion_r2352706415
##########
zookeeper-assembly/pom.xml:
##########
@@ -64,12 +64,6 @@
<artifactId>zookeeper</artifactId>
<version>${project.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.zookeeper</groupId>
- <artifactId>zookeeper-client</artifactId>
- <version>${project.version}</version>
- <type>pom</type>
- </dependency>
Review Comment:
I think it's mainly because we specifically want to exclude some parts of
our dependency tree in Accumulo, because part of our installation instructions
assumes you've already installed some of those. For example, we depend on
Hadoop and ZooKeeper. We don't ship those dependencies in our build, because we
expect the user to add those installations to your Accumulo classpath instead.
Hadoop, in particular, has a bunch of changes between different versions with
widely different dependencies for itself across different versions. You can run
Accumulo on a bunch of different versions of Hadoop, but the dependencies you
need is affected by which Hadoop version you use. So, we don't ship them, and
require you to link them at runtime instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
