smoldenhauer-ish commented on PR #2061: URL: https://github.com/apache/zookeeper/pull/2061#issuecomment-3356584431
Thanks for comments & suggestions. I omitted the curly braces where not needed and simplified the regex to check only for number. Certainly I was overthinking it a bit with ZK_SERVER_HEAP="2g -Xms512". However I kept the default and the inclusion of ZK_SERVER_HEAP as I think there is no need to change the default behavior to have that fixed -Xmx1000m - seems to be a reasonable required default for most cases. Yes, for removing that default, setting the ZK_SERVER_HEAP is necessary, but keeping heap and flag settings in separate vars looks quite reasonable to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
