lfrancke commented on code in PR #2324:
URL: https://github.com/apache/zookeeper/pull/2324#discussion_r2542631271
##########
bin/zkCleanup.sh:
##########
@@ -31,27 +31,44 @@
# use POSIX interface, symlink is followed automatically
ZOOBIN="${BASH_SOURCE-$0}"
ZOOBIN="$(dirname "$ZOOBIN")"
-ZOOBINDIR="$(cd "$ZOOBIN" && pwd)"
+ZOOBINDIR="$(cd "$ZOOBIN" || exit && pwd)"
if [[ -e "$ZOOBIN/../libexec/zkEnv.sh" ]]; then
- # shellcheck source=bin/zkEnv.sh
Review Comment:
Okay, this was probably dumb from me. I removed them because:
```
In zkCleanup.sh line 38:
. "$ZOOBINDIR"/../libexec/zkEnv.sh "$@"
^-- SC1091 (info): Not following: bin/zkEnv.sh: openBinaryFile: does not
exist (No such file or directory)
In zkCleanup.sh line 41:
. "$ZOOBINDIR"/zkEnv.sh "$@"
^-------------------^ SC1091 (info): Not following: bin/zkEnv.sh:
openBinaryFile: does not exist (No such file or directory)
For more information:
https://www.shellcheck.net/wiki/SC1091 -- Not following: bin/zkEnv.sh:
open...
```
But that was because I was running shellcheck from within `bin`.
Sorry, those removals should have never made it into the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
