eolivelli commented on code in PR #2328:
URL: https://github.com/apache/zookeeper/pull/2328#discussion_r2700788726
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java:
##########
@@ -272,6 +272,34 @@ private ServerMetrics(MetricsProvider metricsProvider) {
TTL_NODE_DELETED_COUNT =
metricsContext.getCounter("ttl_node_deleted_count");
TTL_NODE_CREATED_COUNT =
metricsContext.getCounter("ttl_node_created_count");
+
+ /**
+ * Operation count metrics
+ */
+ TOTAL_OP_COUNT = metricsContext.getCounter("total_op_count");
Review Comment:
what about adding a common prefix to all these metrics ?
like "frp_" (final request processor) or "final_request_processor_"
This way the metrics are naturally grouped (and when you explore them with
Grafana or build a dashboard your life is much easier)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
