PDavid commented on code in PR #2345:
URL: https://github.com/apache/zookeeper/pull/2345#discussion_r2821179181


##########
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerTest.java:
##########
@@ -83,7 +83,7 @@ public void testQuorumPeerListendOnSpecifiedClientIP(@TempDir 
File dataDir) thro
     @Test
     public void testShutdownWithoutZkDbDoesNotThrow() throws Exception {
         QuorumPeer peer = new QuorumPeer();
-        peer.shutdown();
+        assertDoesNotThrow(peer::shutdown);

Review Comment:
   Thanks for trying this out. :+1: 
   
   I think this should have worked, just you have to add a static import for 
`org.junit.jupiter.api.Assertions.assertDoesNotThrow` next to the already 
existing static imports, e.g.:
   
   ```
   import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to