PDavid commented on code in PR #2360:
URL: https://github.com/apache/zookeeper/pull/2360#discussion_r2919335649
##########
zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md:
##########
@@ -2296,7 +2304,45 @@ options are used to configure the
[AdminServer](#sc_adminserver).
**New in 3.7.1:**
The timeout in ms for Prometheus worker threads shutdown.
Default value is 1000ms.
-
+
+* *metricsProvider.ssl.keyStore.location* and
*metricsProvider.ssl.keyStore.password*:
+ Specifies the file path to a Java keystore containing the local
+ credentials to be used for PrometheusMetricsProvider TLS connections and the
+ password to unlock the file.
+
+* *metricsProvider.ssl.keyStore.type*:
+ Specifies the file format of the PrometheusMetricsProvider keystore.
Values: JKS, PEM, PKCS12 or null (detect by filename).
+ Default: null.
+
+* *metricsProvider.ssl.trustStore.location* and
*metricsProvider.ssl.trustStore.password*:
+ Specifies the file path to a Java truststore containing the remote
+ credentials to be used for PrometheusMetricsProvider TLS connections and the
+ password to unlock the file.
+
+* *metricsProvider.ssl.trustStore.type*:
+ Specifies the file format of the PrometheusMetricsProvider truststore.
Values: JKS, PEM, PKCS12 or null (detect by filename).
+ Default: null.
+
+* *metricsProvider.ssl.need.client.auth*:
+ Specifies options to authenticate SSL connections from clients.
+ When set to true, PrometheusMetricsProvider will "require" client
authentication.
+ Default: true
+
+* *metricsProvider.ssl.want.client.auth*:
+ Specifies options to authenticate SSL connections from clients.
+ When set to true, PrometheusMetricsProvider will "request" client
authentication.
+ Default: true
Review Comment:
There is already a guide about these here:
https://github.com/apache/zookeeper/blob/master/zookeeper-docs/src/main/resources/markdown/zookeeperMonitor.md#L56
Do you think it makes sense to have these here as well? If not, I can remove
these.
BTW: To be honest I was not sure in which versions these were introduced -
maybe with https://issues.apache.org/jira/browse/ZOOKEEPER-4798 which has the
3.10.0 fix version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
