PDavid commented on code in PR #2359:
URL: https://github.com/apache/zookeeper/pull/2359#discussion_r2922912507
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/JettyAdminServer.java:
##########
@@ -154,6 +154,20 @@ public JettyAdminServer(
sslContextFactory.setTrustStorePassword(certAuthPassword);
sslContextFactory.setNeedClientAuth(needClientAuth);
+ String enabledProtocols =
System.getProperty(x509Util.getSslEnabledProtocolsProperty());
+ if (enabledProtocols != null) {
+ LOG.info("Setting enabled protocols: '{}'",
enabledProtocols);
Review Comment:
Thanks, makes perfect sense. Done.
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/JettyAdminServer.java:
##########
@@ -154,6 +154,20 @@ public JettyAdminServer(
sslContextFactory.setTrustStorePassword(certAuthPassword);
sslContextFactory.setNeedClientAuth(needClientAuth);
+ String enabledProtocols =
System.getProperty(x509Util.getSslEnabledProtocolsProperty());
+ if (enabledProtocols != null) {
+ LOG.info("Setting enabled protocols: '{}'",
enabledProtocols);
+ String[] enabledProtocolsArray =
enabledProtocols.split(",");
+
sslContextFactory.setIncludeProtocols(enabledProtocolsArray);
+ }
+
+ String sslCipherSuites =
System.getProperty(x509Util.getSslCipherSuitesProperty());
+ if (sslCipherSuites != null) {
+ LOG.info("Setting enabled cipherSuites: '{}'",
sslCipherSuites);
Review Comment:
Thanks, makes perfect sense. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
