PDavid commented on code in PR #2369:
URL: https://github.com/apache/zookeeper/pull/2369#discussion_r3020505765


##########
zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeperMain.java:
##########
@@ -332,7 +333,6 @@ void run() throws IOException, InterruptedException {
                 | InstantiationException e
             ) {
                 LOG.debug("Unable to start jline", e);

Review Comment:
   Thanks, good suggestion. 👍 I guess this makes sense, just this way if JLine 
is not missing but we still have an Exception, it won't get logged at all which 
might not be what is desired. 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to