On Thu, 22 Apr 2010 16:06:27 +0200, "Sebastian Spaeth" <sebast...@sspaeth.de> wrote: > > jkr and I noticed that patch series are shown in reverse order now, in > fact threads seem to display messages at the same depth in reverse > chronological order now.
My fault! Sorry about that. On Thu, 22 Apr 2010 10:14:16 -0400, Jesse Rosenthal <jrosent...@jhu.edu> wrote: > Just to follow up on this, it seems that the regression comes from the > fix Carl introduced in 2a1a4f0551 to make his simplification of my patch Indeed that was the problem. And your original code *did* pass the tests I wrote. There are still a couple of cleanups I'd like to make, (like assigning the subject only in _add_matched_message and not uselessly in _add_message as well). But I can do those now without breaking the test suite! > Unfortunately, I'm not quite skilled enough at git to turn back some > files to a certain state, tests to another state, and so on. For now, since the test suite is just a single file, it's easy enough to do: cp test/notmuch-test latest-notmuch-test git checkout HEAD~5 # or whatever make ./latest-notmuch-test Though that doesn't answer the question of how to do this with git. Probably something like: git checkout HEAD~5 git checkout master -- test make test On Thu, 22 Apr 2010 10:31:18 -0400, Jesse Rosenthal <jrosent...@jhu.edu> wrote: > Sorry, got that slightly wrong. The following commits need to be > reverted: > > 36e4459a328b8449b3e9d510be81a332a9b35aaa > f43990ce134d838cdb2cdd5d0752a602e81cfdd9 > 7fb56f9dc5d8e66f717f5e48ecbfbc11c8190182 > > When I do this, search order is right, and all tests are passed. I did this. And before doing it I added a new test to show the regression, (which the reverts then make pass). So in my defense, it wasn't my fault[*] I didn't notice the regression. It was the test suite's fault for not testing "notmuch show" at all. -Carl [*] Except that I'm the one that wrote the test suite and didn't put any "notmuch show" tests into it. Oops!
pgpJxIq4beyqZ.pgp
Description: PGP signature
_______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch