On Mon, 26 Apr 2010 16:09:43 +0100, [email protected] wrote: > From: David Edmondson <[email protected]> [no commit message]
Thanks, David.
Allow me the chance to try to convince you that *every* commit requires
a sentence or two of justification, (beyond the one-line summary just
stating "what" the patch does). There's *always* some utility to saying
"why".
Take this current patch which seems so simple. There were two
declarations, so one had to go. What more could there be to say?
For me, when reviewing this, I wondered "How did there come to be two
different declarations?", and "Is this patch removing the right one?".
So I had to go grep through the source to figure out what had happened.
I could have avoided that if the commit had said something like:
This variable was moved from notmuch.el to notmuch-lib.el some time
ago, but the declaration in notmuch.el was left around. Clean
that up.
[And I just pushed the patch with this added.]
Whether or not that convinces you, perhaps you can humor me and always
try to come up with something to say, even when it seems there's nothing
possible to add. If nothing else, it can be a fun challenge. If you need
more beyond that, you can try writing your commit message as a haiku.
-Carl
--
[email protected]
pgphbOc7KOMcb.pgp
Description: PGP signature
_______________________________________________ notmuch mailing list [email protected] http://notmuchmail.org/mailman/listinfo/notmuch
