On Thu, May 13, 2010 at 07:58:38PM -0700, [email protected] wrote: > > Previously, we were adding our bindings directly to `widget-keymap', > > resulting in them being shared by anything else that used that keymap. > > Is this patch preferable over the one I sent some time ago in > id:[email protected] ? > > My patch makes notmuch-hello a major mode and also creates the proper > keymap. THe major mode allows the '?' keybinding to also work. >
Ah, I failed to properly search the mail archives before sending this. Your patch looks preferable with one exception: I think that making widget-keymap a parent of notmuch-hello-mode-map is probably better than just copying widget-keymap -- if someone defines additional bindings in widget-keymap, we should inherit them whether they are defined before or after notmuch-hello is loaded. (This is also recommended by the documentation for `widget-keymap'). - Nelson _______________________________________________ notmuch mailing list [email protected] http://notmuchmail.org/mailman/listinfo/notmuch
