On Wed, 29 Jun 2011 02:22:31 +0400, Dmitry Kurochkin <[email protected]> wrote: > Ouch. I never saw these. Do you get these in crypto tests only?
Yes. I just found the bug. The crypto tests use emacs_deliver_message to generate signed/encrypted messages, but that function doesn't call increment_mtime between running emacs and running "notmuch new". That means that if the emacs_deliver_message code is fast enough, (less than 1 second), and if the test suite is being run on a lame filesystem without sub-second timestamp granularity (including ext3fs) that the "notmuch new" invocation will not see the mail[*]. I've added a call to increment_mtime and the failures go away. So I've pushed the patch to use emacsclient now. Thanks very much for helping our test suite run faster! -Carl [*] And, yes, this does mean that there are race conditions under which mail can be delivered and notmuch won't see it, (unless subsequent mails are delivered to the same directory). Austin has a plan to fix the use of the mtime timestamp in notmuch, (never storing the current mtime in the database if it's the same as the current time), that should hopefully close this race window. -- [email protected]
pgp57jpDcxJ7N.pgp
Description: PGP signature
_______________________________________________ notmuch mailing list [email protected] http://notmuchmail.org/mailman/listinfo/notmuch
