On Thu, 30 Jun 2011 09:24:12 -0700, Carl Worth <cwo...@cworth.org> wrote: Non-text part: multipart/signed > On Thu, 30 Jun 2011 10:19:49 +0200, Pieter Praet <pie...@praet.org> wrote: > > Alter `do_search_threads()' and `do_search_messages()' > > to not prepend each result with `thread:' respectively `id:'. > > My one concern here is that I've sometimes had a message-id without the > id prefix and run a command like this: > > notmuch search 1309421989-22410-1-git-send-email-pie...@praet.org > > And I've gotten confused when I've received no output, (didn't I receive > that mail? what happened?).
And unfortunately, that's not the only concern. While this patch removes a mere 10 chars, it has (way too) far-reaching consequences, not only for the test suite, but for the entire codebase. Truth be told, this was never intended to be merged. I only sent this patch to give a ~fair chance to what appears to be the general consensus, but I much prefer the fix for do_search_tags() [1]. In fact, all the followup patches (the seemingly haphazard reply nesting is intentional) are intended to be used with the do_search_tags() fix, which I tentatively consider a much cleaner path. > But I think this is a separate bug where the right fix is to make any > search terms with no prefix search through *all* prefixed terms > generated from email content. This would allow us to also avoid indexing > some content twice, (currently we store subject, from, and to both with > a prefix and without a prefix). Indeed a most desirable (albeit perhaps long-term) goal. Much as I'd like, I won't be able to make myself useful in that area for the time being, as the only C I consider myself sufficiently capable of pushing around is the one ending with "offee" :< > -Carl > > -- > carl.d.wo...@intel.com Non-text part: application/pgp-signature Peace -- Pieter [1] id:"1309422029-22924-1-git-send-email-pie...@praet.org" _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch