Hi Dmitry, On Thu, 07 Jul 2011 11:16:03 +0400, Dmitry Kurochkin <dmitry.kuroch...@gmail.com> wrote: > Why do we need to remove `goto-address-mode' overlays if it is not > enabled ((goto-address-mode t) is below is removed)? > [..] > `goto-address-mode' creates buttons not only for email addresses but > also for URLs. Do we loose it now?
Everything `goto-address-mode' does is still in effect, I just replaced (goto-address-mode t) by a call to `goto-address-fontify-region' in notmuch-show-buttonise-links, to ensure that the id links will be buttonised (and the overlay removed after it's actually been inserted) _after_ goto-address does its thing. I could also have left (goto-address-mode t) in and jit-register-lock'ed notmuch-show-buttonise-links before that, but then I would be relying on the fact that fontifiers that are registered first, will be run last. As far as I can tell this is just an implementation detail and might change some day. Cheers, Daniel
pgpsxL2QnOqn6.pgp
Description: PGP signature
_______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
