Quoth Istvan Marko on Jul 12 at 8:07 pm: > Austin Clements <amdra...@mit.edu> writes: > > > I'd say this patch looks good other than coding style > > - Tab indentation > > - /* */ comments, starting with a capital letter > > - Space between function name and open paren > > - Space after comma in argument lists > > - Spaces around assignment operator > > Thanks, fixed the ones I see:
+ /* Fetch header from the appropriate xapian value field if + * available */ + if (strcmp(header, "from") == 0) + value = message->doc.get_value(NOTMUCH_VALUE_FROM); + else if (strcmp(header, "subject") == 0) + value = message->doc.get_value (NOTMUCH_VALUE_SUBJECT); + else if (strcmp(header, "message-id") == 0) + value = message->doc.get_value (NOTMUCH_VALUE_MESSAGE_ID); The strcmp's should have a space before the paren, as should the first get_value. (Yeah, it's weird. Blame glib.) Also, it occurred to me that these should be strcasecmp's, since headers are case-insensitive. _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
