Hello I do not get the failure with just 1/4 applied but do with all 4 applied. The trivial patch below fixes it, but it might not be the best solution.
The failure occurs because Jani's patch changes the behavior of a couple of emacs/notmuch internal functions: the function notmuch-search-reply-to-thread is renamed to notmuch-search-reply-all-to-thread and a new notmuch-search-reply-to-thread function is added (which does reply to sender) and a similar change for notmuch-show-reply-.. . Since the keybindings are also remapped the user will not notice any difference. However, if the user has any key-bindings etc in their .emacs file the behaviour could change. It might be preferable to keep the existing functions as they are and give the new reply-to-sender functions a new name. Best wishes Mark diff --git a/test/emacs b/test/emacs index a06c223..5047d46 100755 --- a/test/emacs +++ b/test/emacs @@ -258,7 +258,7 @@ test_expect_equal_file OUTPUT EXPECTED test_begin_subtest "Reply within emacs" test_emacs '(notmuch-search "subject:\"testing message sent via SMTP\"") (notmuch-test-wait) - (notmuch-search-reply-to-thread) + (notmuch-search-reply-all-to-thread) (test-output)' sed -i -e 's/^In-Reply-To: <.*>$/In-Reply-To: <XXX>/' OUTPUT cat <<EOF >EXPECTED _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch