On 01/27/2012 05:42 AM, Tomi Ollila wrote:
On Thu, 26 Jan 2012 13:03:46 +0000, Jani Nikula<[email protected]> wrote:
On Thu, 26 Jan 2012 12:11:57 +0200, Tomi Ollila<[email protected]> wrote:
Moved _notmuch_get_list () and _notmuch_set_list () to a location
in notmuch-config.c so that new functions that will be located
before the old location of those functions can also use these.
Parse error. ;)
You mean something along the lines of: "Move _notmuch_get_list () and
_notmuch_set_list () earlier in the file to avoid forward declarations
in further work. No functional changes."
I'm sure native speakers can bikeshed that further. ;)
Ok, they haven't. I'n resubmit this alone with better commit
message -- I look the other after I have better time.
As a native speaker, your new version is acceptable but I found "in
further work" a little odd. (Depending on what you meant, I'd say "in
upcoming patches".) The thing I found most confusing about the comment
is that the functions aren't called _notmuch_get_list or
_notmuch_set_list (instead they are _config_get_list and _config_set_list.)
Ethan
_______________________________________________
notmuch mailing list
[email protected]
http://notmuchmail.org/mailman/listinfo/notmuch
