On Wed, Nov 14 2012, Ethan Glasser-Camp wrote: > Austin Clements <[email protected]> writes: > >> This is v2 of id:"[email protected]". >> This makes Jani's suggested additions to the regexp and adds support >> for RFC 2392 mid: links, as suggested by Sascha. > > This series looks fine to me.
LGTM too. although this is different than others in test/emacs: +test_expect_equal_file EXPECTED OUTPUT (grep test_expect_equal_file test/emacs) The diff output in case of failure makes more sense when the args are in this order -- but probably that should be changed bu changing the arg handling order in test_expect_equal_file (to be consistent with test_expect_equal) and then change the order in the "remaining" uses of test_expect_equal_file EXPECTED OUTPUT. > Ethan Tomi _______________________________________________ notmuch mailing list [email protected] http://notmuchmail.org/mailman/listinfo/notmuch
