Jani Nikula <[email protected]> writes:

> The code filled with #ifdef GMIME_ATLEAST_26 is difficult to
> read. Abstract the decryption and signature verification into
> functions, with separate implementations for GMime 2.4 and 2.6, to
> clarify the code.

This series mostly looks OK, although it's a challenge to track all the
code movement.

I'd like some way to make it more obvious to the reader which version of
the functions they are reading (when the #ifdef GMIME_ATLEAST_26 has
scrolled off screen). The simplest would just be a comment in front of
each function.

d



_______________________________________________
notmuch mailing list
[email protected]
http://notmuchmail.org/mailman/listinfo/notmuch

Reply via email to