On Tue, Apr 09 2013, David Bremner wrote: > Tomi Ollila <[email protected]> writes: > >> On Tue, Apr 09 2013, Jed Brown wrote: >> >>> David Bremner <[email protected]> writes: >>> >>>> Squashed sounds good to me too. Sorry I'm too lazy/busy at the moment to >>>> do it myself. >>> >>> I tested the attached and it's working as expected. Sent as an >>> attachment to preserve author information. >> >> LGTM (this time tested, too). Also compared diffs by hand, change as >> announced. >> comments in id:[email protected] (amend!) apply. > > There seems to be a few warnings: > > In notmuch-bbdb/snarf-from: > notmuch-address.el:116:26:Warning: reference to free variable > `bbdb-get-addresses-headers' > > In notmuch-bbdb/snarf-to: > notmuch-address.el:122:29:Warning: reference to free variable > `bbdb-get-addresses-headers' > > In end of data: > notmuch-address.el:143:1:Warning: the following functions are not known to be > defined: bbdb-get-addresses, bbdb-update-records, notmuch-show-get-header > > Do we need a few defvars?
For the above set, something like: (defvar bbdb-get-addresses-headers) (declare-function notmuch-show-get-header "notmuch-show" (header &optional props)) (declare-function bbdb-get-addresses "bbdb-com" (only-first-address uninteresting-senders get-header-content-function &rest get-header-content-function-args)) (declare-function bbdb-update-records "bbdb-com" (addrs auto-create-p offer-to-create)) > d Tomi _______________________________________________ notmuch mailing list [email protected] http://notmuchmail.org/mailman/listinfo/notmuch
