Mark Walters <markwalters1...@gmail.com> writes: > On Tue, 15 Jul 2014, David Bremner <da...@tethera.net> wrote: >> Mark Walters <markwalters1...@gmail.com> writes: >>> + (cond ((eq major-mode 'notmuch-show-mode) >>> + (notmuch-show-get-message-properties)) >>> + ((eq major-mode 'notmuch-tree-mode) >>> + (notmuch-tree-get-message-properties)))) >> >> I see this already existed, but it looks weird to me to have a two test >> cond with no else. Is it intentional to have the code drop through and >> do nothing if neither case matches? It seems like it might be better to >> signal an error. > > I can definitely do that. But as a comparison > notmuch-search-get-result and notmuch-search-find-thread-id "work" in > any buffer in the sense of returning nil but not complaining so perhaps > the current version is more consistent. >
It occurs to me that we can fix all 3 places in a followup patch, so I'll push this for now. d _______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
