Mark Walters <markwalters1...@gmail.com> writes: > default-value needs its argument to be quoted. > ---
Hi Mark, I really appreciate you sending in a bug fix. Thanks! I'd prefer to see the commit message describing the bug and the fix a bit. You do have some text here that would be a great addition to the commit message: > Slightly strangely default-value of 't or nil is 't or nil > respectively so the code didn't give an error but just did the wrong > thing. But even beyond that. What is the "wrong thing" that the code did here? Imagine someone (me!) trying to read and review the patch without ever encountering the bug before. How can I test the bug both before and after applying the patch? I'd really like to see that information in the commit message. Thanks, -Carl
pgpkfzqsTF18i.pgp
Description: PGP signature
_______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
