On Mon, Sep 22 2014, Michal Sojka <sojk...@fel.cvut.cz> wrote:

> Many functions that implement the search command need to access command
> line options. Instead of passing each option in a separate variable, put
> them in a structure and pass only this structure.

This patch looks good to me. 

Although the test and the implementation in the next patches look OK, I'd
prefer the FLAG implementation Jani suggested earlier. IMO now that I
compare these two it looks cleaner and simpler...

I.e. I'd prefer notmuch search --output=sender --output=recipients ...
(same output regardless the order these options given).

I'd postpone the unique handling to a bit later phase; there are quite a
few options how to do that (*)


Tomi

(*) IMO the default unique (when requested) would be exact case-sensitive
match of full name & address parts (phrase, address & comment); then
(a subset of possible) options could be: 
   +) case-insensitive (first match taken (or last match?) -- option?)
   +) unique email addresses (take phrase/comment from first/last?)
      --  or use first that has something additional to plain address
      --  or use last  that has something additional to plain address


> This will become handy in the following patches.
> ---
>  notmuch-search.c | 122 
> ++++++++++++++++++++++++++++---------------------------
>  1 file changed, 62 insertions(+), 60 deletions(-)
>
> diff --git a/notmuch-search.c b/notmuch-search.c
> index bc9be45..5ac2a26 100644
> --- a/notmuch-search.c
> +++ b/notmuch-search.c
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Reply via email to