On Thu, Oct 02, 2014 at 04:39:41PM -0400, Austin Clements wrote: > On Thu, 02 Oct 2014, W. Trevor King wrote: > > On Thu, Oct 02, 2014 at 03:19:08PM -0400, Austin Clements wrote: > >> This patch simplifies notmuch_database_close to explicitly abort > >> any outstanding transaction and then just call Database::close. > >> This works for both read-only and read/write databases, takes > >> care of committing changes, unifies the exception handling path, > >> and codifies aborting outstanding transactions. > > > > I don't expect atomic blocks are particularly useful for read-only > > connections. If they aren't, I'd quibble with the “This works for > > both read-only…” wording above. If they are, I'd drop the > > read/write > > It's true that atomic sections aren't very useful on a read-only > database, but we do allow them for symmetry.
Heh, and they're no-ops since the beginning in 957f1ba3 (lib: Add notmuch_database_{begin,end}_atomic, 2011-01-29). So both the commit message and read/write check make sense. Quibble retracted. Cheers, Trevor -- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc
Description: OpenPGP digital signature
_______________________________________________ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch