Hi

> From: Charles Celerier <ccel...@cs.stanford.edu>
>
> The notmuch-search-terms man page states that "tag:<tag>" is equivalent
> to "is:<tag>". Completion for "is:<tag>" style searches is now supported
> in the Emacs interface.
>
> Amended by David Bremner: combine lexical-let and let into
> lexical-let*

This version looks good to me; it works and passes all tests. +1

Note it does not apply to master but only needs a tiny fixup (see below)

Best wishes

Mark

> ---
>  emacs/notmuch.el | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index 218486a..1b6971e 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -855,13 +855,15 @@ See `notmuch-tag' for information on the format of 
> TAG-CHANGES."
>    "Read a notmuch-query from the minibuffer with completion.
>  
>  PROMPT is the string to prompt with."
> -  (lexical-let
> -      ((completions
> -     (append (list "folder:" "path:" "thread:" "id:" "date:" "from:" "to:"
> -                   "subject:" "attachment:")
                                        
^ this line now has a "mimetype:" final option

> -             (mapcar (lambda (tag)
> -                       (concat "tag:" (notmuch-escape-boolean-term tag)))
> -                     (process-lines notmuch-command "search" "--output=tags" 
> "*")))))
> +  (lexical-let*
> +      ((all-tags
> +        (mapcar (lambda (tag) (notmuch-escape-boolean-term tag))
> +                (process-lines notmuch-command "search" "--output=tags" 
> "*")))
> +       (completions
> +      (append (list "folder:" "path:" "thread:" "id:" "date:" "from:" "to:"
> +                    "subject:" "attachment:")
> +              (mapcar (lambda (tag) (concat "tag:" tag)) all-tags)
> +              (mapcar (lambda (tag) (concat "is:" tag)) all-tags))))
>      (let ((keymap (copy-keymap minibuffer-local-map))
>         (current-query (case major-mode
>                          (notmuch-search-mode (notmuch-search-get-query))
> -- 
> 2.1.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Reply via email to