On Sat, Jun 13 2015, Mark Walters wrote: > Change the key binding for filter (or "limit") in search-mode. This > gives consistency with the new filter in show-mode, and frees 'f' for > forward-thread in the future.
Is there a conclusion on this change? The patch itself seems obviously fine from a code perspective, at issue is more whether it's acceptable to change the key binding. The equivalent binding in notmuch-show mode is already "l", and I think that it makes sense to be consistent (i.e. the change should be applied). > --- > emacs/notmuch.el | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el > index 6564816..06e3b94 100644 > --- a/emacs/notmuch.el > +++ b/emacs/notmuch.el > @@ -166,7 +166,7 @@ (defvar notmuch-search-mode-map > (define-key map "o" 'notmuch-search-toggle-order) > (define-key map "c" 'notmuch-search-stash-map) > (define-key map "t" 'notmuch-search-filter-by-tag) > - (define-key map "f" 'notmuch-search-filter) > + (define-key map "l" 'notmuch-search-filter) > (define-key map [mouse-1] 'notmuch-search-show-thread) > (define-key map "*" 'notmuch-search-tag-all) > (define-key map "a" 'notmuch-search-archive-thread) > @@ -983,7 +983,7 @@ (defun notmuch-search-toggle-order () > (notmuch-search-refresh-view)) > > (defun notmuch-search-filter (query) > - "Filter the current search results based on an additional query string. > + "Filter or LIMIT the current search results based on an additional query > string. > > Runs a new search matching only messages that match both the > current search results AND the additional query string provided." > -- > 2.1.4 _______________________________________________ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch