On Mon, Dec 14 2015, Mark Walters wrote: > This is just a rebased (to current master) version of > id:1414172643-28270-1-git-send-email-...@dme.org (git did the rebase by > itself using a three-way merge) > > I will send some review comments as replies to this thread.
I didn't see any, but in general I think: - the core notmuch changes should be okay to commit (presuming that they still apply cleanly), - the emacs UI changes need some careful consideration. There is some small loss of functionality alluded to in id:1414172643-28270-1-git-send-email-...@dme.org: % - More improvements to the code that renders the authors are possible % (to improve the chosen break between visible and invisible), but a % planned re-write of the `notmuch-search-result-format' code would % render that irrelevant. Fixing that properly requires the further changes to how search results are presented. Those changes were never finished. > > Best wishes > > Mark > > > David Edmondson (3): > search: Separately report matching and non-matching authors. > emacs: Improved display of matching/non-matching authors. > test: Update tests for 'authors_matched' and authors_non_matched'. > > emacs/notmuch.el | 64 ++++++++++++++------------ > notmuch-search.c | 105 > +++++++++++++++++++++++++++++++++++++++++++ > test/T160-json.sh | 9 ++++ > test/T170-sexp.sh | 4 +- > test/T470-missing-headers.sh | 8 ++++ > 5 files changed, 159 insertions(+), 31 deletions(-) > > -- > 2.1.4 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch _______________________________________________ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
