Daniel Kahn Gillmor <[email protected]> writes:
> + status = _notmuch_message_delete (message); > + if (status) /* we'll report the last failure we see; > + * if there is more than one failure, we > + * forget about previous ones */ > + last_error = status; I was initially worried/paranoid that there might be some risk of data loss by continuing deleting after the first bad status; that doesn't seem to be the case, but there doesn't seem to be much advantage in continuing either, since the only error currently returned from _notmuch_message_delete is from _notmuch_database_ensure_writable, which seems likely to persist. So perhaps exiting the loop on the first error might be less confusing. Other than that, and my bug in ghost-report, the series looks good to me. d _______________________________________________ notmuch mailing list [email protected] https://notmuchmail.org/mailman/listinfo/notmuch
