On Sun, May 08 2016, David Bremner <[email protected]> wrote: > This obsoletes > > id:[email protected]
looks pretty good & tests pass. one problem though, rest are nits: ;; This buffer is for notes you don't want to save, and for Lisp evaluation. ;; If you want to create a file, visit that file with C-x C-f, ;; then enter the text in that file's own buffer. *** in id:[email protected] + -DHAVE_XAPIAN_FIELD_PROCESSOR=\$(HAVE_XAPIAN_PROCESSOR) \\ build gives compile /warning/ there, unfortunately this is not fatal and therefore can go unnoticed. -Wundef would do the same, complain about undefined macro but would not be fatal. then, some more nits: *** id:[email protected] +_notmuch_config_list_options () { *** id:[email protected] +typedef enum dump_includes { + DUMP_INCLUDE_TAGS=1, + DUMP_INCLUDE_CONFIG=2, +} dump_include_t; print_dump_header () has some empty lines before closing '}' *** id:[email protected] +process_config_line(notmuch_database_t *notmuch, const char* line){ + val_p = strtok_len_c(key_p+key_len, delim, &val_len); + int include=0; *** id:[email protected] +/* query-fp.cc - "query:" field processor glue glue id:[email protected] +_notmuch_config_list_built_with () { _______________________________________________ notmuch mailing list [email protected] https://notmuchmail.org/mailman/listinfo/notmuch
