Daniel Kahn Gillmor <[email protected]> writes:
> + status = _notmuch_crypto_get_gmime_ctx_for_protocol
> (&(indexopts->crypto),
> + protocol, &crypto_ctx);
> + if (status) {
> + _notmuch_database_log (notmuch, "Warning: setup failed for decrypting "
> + "during indexing. (%d)\n", status);
> + status = notmuch_message_add_property (message, "index-decryption",
> "failure");
> + if (status)
> + _notmuch_database_log (notmuch, "failed to add index-decryption "
> + "property (%d)\n", status);
> + return;
> + }
Currently the only correct usage of _notmuch_database_log is the
following pattern
_notmuch_database_log (notmuch, "Cannot write to a read-only
database.\n");
return NOTMUCH_STATUS_READ_ONLY_DATABASE;
In particular, the log buffer is only one line, and the caller needs to
know to retrieve it.
I agree it's not ideal, but I doubt you want to delay your stuff in
order to extend/fix the internal logging API.
d
_______________________________________________
notmuch mailing list
[email protected]
https://notmuchmail.org/mailman/listinfo/notmuch
