On Fri, Oct 07 2016, Mark Walters <[email protected]> wrote: > Currently, by default k invokes the tag-jump menu, and following it by > r invokes the reverse tag change jump menu. This is awkward to type > (e.g. k r u for undoing a -unread change). This changes it so that k > followed by k invokes the reverse menu. We make the key for the > reverse map a variable as that makes it possible for a user to > change it by editing their .emacs file. > ---
LGTM. > > I think this is the right solution (suggested by Tomi on > irc). Previously it was not possible for the user to configure this > binding without some substantial lisp, or patching the source. > > Best wishes > > Mark > > > > id:[email protected] > > > emacs/notmuch-tag.el | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el > index 49662c2..c03027f 100644 > --- a/emacs/notmuch-tag.el > +++ b/emacs/notmuch-tag.el > @@ -485,6 +485,9 @@ begin with a \"+\" or a \"-\". If REVERSE is non-nil, > replace all > s))) > tags)) > > +(defvar notmuch-tag-jump-reverse-key "k" > + "The key in tag-jump to switch to the reverse tag changes.") > + > (defun notmuch-tag-jump (reverse) > "Create a jump menu for tagging operations. > > @@ -523,9 +526,10 @@ and vice versa." > (push (list key name-string > `(lambda () (,tag-function ',tag-change))) > action-map))) > - (push (list "r" (if reverse > - "Forward tag changes " > - "Reverse tag changes") > + (push (list notmuch-tag-jump-reverse-key > + (if reverse > + "Forward tag changes " > + "Reverse tag changes") > (apply-partially 'notmuch-tag-jump (not reverse))) > action-map) > (setq action-map (nreverse action-map)) > -- > 2.1.4 > > _______________________________________________ > notmuch mailing list > [email protected] > https://notmuchmail.org/mailman/listinfo/notmuch _______________________________________________ notmuch mailing list [email protected] https://notmuchmail.org/mailman/listinfo/notmuch
