On Wed, 12 Oct 2016, Mark Walters <markwalters1...@gmail.com> wrote: > On Tue, 11 Oct 2016, m...@bubblegen.co.uk wrote: >> From: Matthew Lear <m...@bubblegen.co.uk> >> To: email@example.com >> Cc: Matthew Lear <m...@bubblegen.co.uk> >> Subject: [PATCH] Fix reply to encrypted mail when discouraging plain text. >> Date: Tue, 11 Oct 2016 22:24:18 +0100 >> Message-Id: <1476221058-10431-1-git-send-email-m...@bubblegen.co.uk> >> X-Mailer: git-send-email 2.4.10 >> >> If an encrypted multipart message is received which contains html and >> notmuch-multipart/alternative-discouraged is set to discourage "text/plain", >> any encrypted parts are not decrypted during generation of the reply >> text. This fixes that problem by making sure notmuch-mua-reply does >> that. > > Hi > > I haven't tested this but it looks correct: more broadly I think this is > needed whenever notmuch-show has to get a part directly rather than just > from the sexp reply.
Hi Just to confirm I have now tested this -- it compiles and test suite passes. (Note I don't have suitable encrypted messages to test). Anyway LGTM +1 Best wishes Mark > > Best wishes > > Mark > > >> --- >> emacs/notmuch-mua.el | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el >> index c567173..f333655 100644 >> --- a/emacs/notmuch-mua.el >> +++ b/emacs/notmuch-mua.el >> @@ -251,6 +251,10 @@ mutiple parts get a header." >> (notmuch-show-max-text-part-size 0) >> ;; Insert headers for parts as appropriate for replying. >> (notmuch-show-insert-header-p-function >> notmuch-mua-reply-insert-header-p-function) >> + ;; Ensure that any encrypted parts are >> + ;; decrypted during the generation of the reply >> + ;; text. >> + (notmuch-show-process-crypto process-crypto) >> ;; Don't indent multipart sub-parts. >> (notmuch-show-indent-multipart nil)) >> ;; We don't want sigstatus buttons (an information leak and >> usually wrong anyway). >> -- >> 2.4.10 >> >> _______________________________________________ >> notmuch mailing list >> firstname.lastname@example.org >> https://notmuchmail.org/mailman/listinfo/notmuch _______________________________________________ notmuch mailing list email@example.com https://notmuchmail.org/mailman/listinfo/notmuch