On Thu, 20 Oct 2016 13:47:40 -0300, David Bremner <[email protected]> wrote: > Franz Fellner <[email protected]> writes: > > > Probably a little bit off-topic, but somewhat related. > > There is a wild mix of TABs and spaces used for indenting all over the > > place. > > I had a hard time to follow the code. Could there be done something? > > Do we have some sort of coding style? If not could we agree on some? At > > least > > for such important things as indentation... It is possible to use e.g. > > astyle > > to apply the formatting automatically. > > > > Franz > > from devel/STYLE: > > * Indent is 4 spaces with mixed tab/spaces and a tab width of 8. > (Specifically, a line should begin with zero or more tabs followed > by fewer than eight spaces.)
>From a quick visual scan at least half the indented lines start with 4 spaces instead of TABS. As I understand the quoted paragraph that should be wrong. > that _should_ be enforced by devel/uncrustify.cfg When was uncrustify used the last time? I simply ran it on lib/database.cc and it produced a diff with 661 lines - the leading spaces were NOT fixed ;) > On the other hand, there are also no doubt places in the code where this > rule is not adhered to. At the risk of being clichéd, whitespace fixup > patches are welcome. Well, I could do it but I won't do it by hand ;) If we can fix the uncrustify.cfg I would be happy to submit patches. > Finally, it might help to have some settings whatever editor you are > using. I'm happy add a file to add a project .vimrc [1] (or whatever editor > people are using) to complement the .dir-locals.el that is there. Instead of using special config files for every editor we could also stick to editorconfig: http://editorconfig.org/
_______________________________________________ notmuch mailing list [email protected] https://notmuchmail.org/mailman/listinfo/notmuch
