Excerpts from Carl Worth's message of Fri Dec 18 09:33:43 -0800 2009: > On Fri, 18 Dec 2009 08:59:55 -0400, david at tethera.net wrote: > > It took me a little work to apply Scott's patch, so rather than asking > > him to resend it from git-send-email, I am just sending. I hope no-one > > is offended (much). > > I think that's great! Collaboration is what this is all about.
Me too! I've never used git-send-email. I'll give it a whirl on my next patch. > > I'm thinking that the patch I sent out last night to only dump message > > ids could be reworked to use the framework of this patch. I also > > think it would be reasonably simple to add an --output=mbox option, > > for archiving and so on. > > I think that selecting *what* to emit is orthogonal from selecting *how* > to format that output. See some ideas in the TODO file, (where I > proposed --for and --format options for these). Having a way to do mbox > output for export would indeed be very nice. Haha! I originally used "--format" and changed for some reason that escapes me now. Implementing an "mbox" formatted output in the current logic wouldn't be archive perfect. The message body is emitted on a per-part basis. What I would do is change the semantics of format->body to be called from show_message. Then the text and json parts would point at the original implementation passing off their per-part function pointers. And, a new mbox implementation would just dump the full message body. -- Scott Robinson | http://quadhome.com/ Q: Why are my replies five sentences or less? A: http://five.sentenc.es/