On Wed, 24 Feb 2010 10:26:47 -0800, Carl Worth <cworth at cworth.org> wrote: > On Wed, 17 Feb 2010 14:33:11 +0100, "Sebastian Spaeth" <Sebastian at > SSpaeth.de> wrote: > > On Tue, 19 Jan 2010 17:54:16 -0500, Jameson Rollins <jrollins at > > finestructure.net> wrote: > > > This patch is intended to greatly simplify the handling of the > > > "unread" tag in the emacs UI. This patch adds a new function > > > 'notmuch-show-mark-read', that removes the "unread" tag in > > > notmuch-show-mode. This function is then executed as a > > > notmuch-show-hook, and by notmuch-show-next-message. All of the > > > functions that explicitly marked messages as unread are removed or > > > renamed.
> Thanks for contributing the patch. This exact feature, (removing all > commands with "and mark read" in their names), has been on my todo list > for too long, and I'm anxious to remove it from that. But... > > > It then checks the unread status in order to decide whether to proceed > > to the next again. So with your patch notmuch-show-next-unread-message > > will skip through all messages in a thread thinking they are all read > > (and actually marking all as read). > > ...that seems like a fatal bug in this script. Thanks for noting that > Sebastian. I certainly don't see it as fatal, but it is something we should resolve. I think the simplification that the patch provides is worth it. I'm seeing the notmuch-show-next-unread-message as a non-interactive function that's not currently called by any other functions, and is therefore not being used. Sebastian, are you using that in a private function, or am I misreading the code? jamie. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100224/c659445a/attachment-0001.pgp>