> But you might actually like that change since it's one you requested in > your first version of the modular test suite. I'm dropping the annoying > execute_expecting macro that both runs notmuch and tests the > output. There's now a much cleaner separation such as: > > output=$($NOTMUCH search for-something) > pass_if_equal "$output" "something was found"
It's definitely better than before. The current implementation of pass_if_equal has IMHO one drawback - if it compares multiline text and there is a difference, it is quite hard to see where. In my tests for maildir synchronization I use this approach: notmuch search tag:inbox | filter_output > actual && diff -u - actual <<EOF thread:XXX 2000-01-01 [1/1] Notmuch Test Suite; test message 3 (inbox) EOF Thanks to the usee of diff, I immediately see only the differences. -Michal