On Wed, 28 Apr 2010 11:45:41 +0100, dme at dme.org wrote: > From: David Edmondson <dme at dme.org> > > If a single header is more than 200 characters long a set of 'off by > one' errors cause memory corruption. ... > This is the cause of my segmentation fault (or bus error) during > `notmuch reply'. The patch is for the 0.3.1 branch, but I'd expect > that it will apply cleanly to master.
Thanks for the fix, David. In my testing I found that it was a header of *exactly* 200 bytes that caused a problem. I added a message with such a header to the test suite and verified (with valgrind) that the old code was problematic. I've now pushed out both your fix and the new test case. -Carl (happy to be hacking on notmuch again) -- carl.d.worth at intel.com -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100603/5da6b73e/attachment.pgp>
