On Sun, May 8, 2011 at 5:54 PM, Florian Friesdorf <flo at chaoflow.net> wrote:
> On Sun, 8 May 2011 17:40:54 -0400, Austin Clements <amdragon at mit.edu> 
> wrote:
>> Also, existing code conventionally uses a variable named "local"
>> for function-level talloc contexts such as your ctx_quote.
> In notmuch-search.c there is no variable named "local", in the other
> functions its also named ctx_quote. Should I rename all ctx_quote to
> "local"?

Huh, sure enough.  Looks like the library uses "local" consistently,
but the CLI uses ctx_quote multiple times and "local" appears only
once, so, yeah, stick with ctx_quote.

Reply via email to