> On Sun, 29 May 2011 20:04:00 +0400 > Dmitry Kurochkin <dmitry.kurochkin at gmail.com> wrote: > > Hi Dima. > > On Sun, 29 May 2011 01:56:28 -0700, notmuch at dima.secretsauce.net > wrote: > > From: Dima Kogan <dima at secretsauce.net> > > > > --- > > > > Hi. > > > > I made a few improvements to the emacs UI. This patch allows the > > user to scroll through the most recent searches with C-up and > > C-down while in the search box. > > > > This sounds like a very nice improvement to me! I just have one > concern: Why C-up and C-down? I believe M-p and M-n would be more > natural for Emacs users (at least for me :)). > > Also, I did not read the code and can not comment on it. But notmuch > coding style is to use tabs for indentation. I guess .dir-locals.el > should be improved to set coding style variables for all modes, not > just C. > > Regards, > Dmitry
Hi. I have a mild preference to C-up/down, but M-n/p is just fine also. As for the coding style, I've looked through that file (notmuch-hello.el), and it doesn't seem to have a consistent style as far as tabs/spaces go. I'm happy to change my patch to conform, but I don't know what I should be conforming to. Should I be tab-ing all indents, or just some?