On Mon, 27 Jun 2011 17:03:03 -0600, Mark Anderson <MarkR.Anderson at amd.com>
wrote:
> On Mon, 27 Jun 2011 15:50:47 -0500, Austin Clements <amdragon at mit.edu>
> wrote:
> > This looks great (modulo one bug, below). I've wanted to run the
> > tests on tmpfs before, but was too lazy to actually fix the tests.
Yes, it does look great. Thanks for the patch, Mark!
Did you miss Austin's note about a possible bug? (You quoted it but
didn't reply). See below:
> > > ?run_test(){
> > > - ? ?result=$(LD_LIBRARY_PATH=../../lib ./symbol-test 2>&1)
> > > + ? ?result=$(LD_LIBRARY_PATH=$TEST_DIRECTORY/../../lib ./symbol-test
> > > 2>&1)
> >
> > Did you mean $TEST_DIRECTORY/../lib?
If you could follow up with an updated patch, (or an argument that the
original patch is correct), that would be great.
-Carl
--
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20110628/c60d2f39/attachment.pgp>
