On Fri, 25 Nov 2011 11:54:51 +0100, Amadeusz ?o?nowski <aidecoe at
aidecoe.name> wrote:
>
> +$(dir)/symbol-test: $(dir)/symbol-test.o
> + $(call quiet,CC) $^ -o $@ -Llib -lnotmuch -lxapian
I'm a bit surprised no -I is neaded here. Is that taken care in the CC call?
> .PHONY: test check
> -test: all $(dir)/smtp-dummy
> +test: all $(dir)/smtp-dummy $(dir)/symbol-test
> @${dir}/notmuch-test $(OPTIONS)
The instructions were already wrong, but maybe they should be updated to
point out that calling the test scripts directly requires smtp-dummy and
symbol-test already be built. Or maybe the tests should check for these
binaries as pre-reqs along with emacs, gpg, etc...
> + -e
> "/^(emacs.expected-output|smtp-dummy|smtp-dummy.c|test-verbose|symbol-test.cc|symbol-test|symbol-test.o)/d"
> \
I wonder if this should be shortened (and made a bit sloppier) with the
use of regexes.
