On Fri, 25 Nov 2011 13:43:35 -0500, David Bremner <david at tethera.net> wrote: > Just confirm, all the crypto tests pass with this patch? In that case, > can we have the patch (preferably as generated by git-send-email)? Or > did I miss it somewhere in this thread?
I don't believe the patch ever made it to the list, I can't find it in my own archive. From the changelog here: http://koji.fedoraproject.org/koji/buildinfo?buildID=269819 it looks like Karel Kl?? of Red Hat created it back in July, I assume that's when Fedora moved to the later GMime version. The patch itself looks like it's a straight re-mapping of the 2.4 GMimeSignatureValidity to the 2.5+ equivalent along with some deprecation of GMimeSession, so just applying the patch will break compilation for anyone < 2.5. Also, three of the crypto tests relating to signature validation /do/ fail, although it looks like that may simply be down to changes in the output format and so just need updated test cases. I've attached the patch as-is to this mail for reference purposes, but based on the above it'll need a bit of tweaking before it's useful to the wider group. -------------- next part -------------- A non-text attachment was scrubbed... Name: notmuch-0.6.1-gmime.patch Type: text/x-patch Size: 9862 bytes Desc: Fedora GMime Patch URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111125/6acb206f/attachment.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111125/6acb206f/attachment.pgp>