On Mon, 23 Jan 2012 18:05:44 +0000, David Edmondson <dme at dme.org> wrote: > When checking for a running emacs, test_emacs evaluates the empty list > '()'. This returns 'nil' when emacs is running, which is then > prepended to the actual test result. Given that it is not part of the > actual test output the test harness can incorrectly report test > failure (or success). > --- > > Commentary updated. >
LGTM Regards, Dmitry > test/test-lib.sh | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/test/test-lib.sh b/test/test-lib.sh > index 0da60fb..82c686c 100644 > --- a/test/test-lib.sh > +++ b/test/test-lib.sh > @@ -926,7 +926,7 @@ test_emacs () { > --eval '(orphan-watchdog $$)'" || return > EMACS_SERVER="$server_name" > # wait until the emacs server is up > - until test_emacs '()' 2>/dev/null; do > + until test_emacs '()' >/dev/null 2>/dev/null; do > sleep 1 > done > fi > -- > 1.7.8.3 > > _______________________________________________ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch